Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update signer scheme for second bridge #436

Merged
merged 3 commits into from
Apr 24, 2024
Merged

feat: update signer scheme for second bridge #436

merged 3 commits into from
Apr 24, 2024

Conversation

wwestgarth
Copy link
Contributor 

{
    "vega": "10909-chain-in-signatures",
    "system-tests": "update-signer-scheme"
}

@wwestgarth wwestgarth self-assigned this Apr 23, 2024
jeremyletang
jeremyletang reviewed Apr 24, 2024
View reviewed changes
ethereum/commands.go Outdated Show resolved Hide resolved
@jeremyletang
chore: Update ethereum/commands.go
3987aef 
change argument from --chain_id to --chain-id
jeremyletang
jeremyletang reviewed Apr 24, 2024
View reviewed changes
ethereum/commands.go Outdated Show resolved Hide resolved
jeremyletang
jeremyletang reviewed Apr 24, 2024
View reviewed changes
ethereum/commands.go Outdated Show resolved Hide resolved
@jeremyletang jeremyletang marked this pull request as ready for review April 24, 2024 12:31
@jeremyletang jeremyletang merged commit 6483dc5 into develop Apr 24, 2024
4 of 11 checks passed
@jeremyletang jeremyletang deleted the update-signer-scheme branch April 24, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremyletang jeremyletang jeremyletang left review comments

Assignees

@wwestgarth wwestgarth

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wwestgarth @jeremyletang